Add a type to the v1 model for the updated ClusterConfig #489
Conversation
jan-g
requested review from
RafalKorepta,
chrisseto,
andrewstucki and
gene-redpanda
as code owners
|
This is mostly to invite comment about the proposed attribute for cluster config (we'll do something similar for node configuration rather than splitting the AdditionalConfiguration up according to prefix). I think this needs to be merged with the current configuration - but because we want late binding of external secrets, we'll have to teach the configuration subcommand to pre-process a |
| // If the value is supplied by an external source, coordinates are embedded here. | ||
| // For non-string target types, the string value fetched from the source will be treated as | ||
| // a value encoded according to YAML rules. | ||
| ExternalSecretRef *struct { |
There was a problem hiding this comment.
the original agreement was that this feature will pretty much be hidden, also I think we'll be using just secret name as a generic/platform agnostic pointer to what you want to read.
We can also emit this from the first implementation.
For reference, what I am going to get from controlplane is ${secrets.PASSWORD}
jan-g
force-pushed
the
v1-cluster-config
branch
2 times, most recently
from
b062c01 to
4e9761c
Compare
This is a placeholder commit to get feedback before we go too far down that path - we'll add the CRD definition once we get agreement on it.
This is exceedingly ugly; it's a placeholder. The entire machinery here needs replacing with something simplified and tidied up.
This requires some additional behaviour from the `configure` subcommand.
jan-g
force-pushed
the
v1-cluster-config
branch
3 times, most recently
from
b4f3d8d to
c9067e8
Compare
Some resolvers need to run late (the external secret resolver in particular) in order to not pollute the k8s resource with secret matter.
This is a placeholder commit to get feedback before we go too far down that path - we'll add the CRD
definition once we get agreement on it.