Create lint and test CI for helm charts #357
Conversation
RafalKorepta
requested review from
chrisseto and
andrewstucki
as code owners
RafalKorepta
force-pushed
the
rk/k8s-464/re-run-gotohelm-and-others
branch
13 times, most recently
from
e584264 to
5f7628a
Compare
| @@ -226884,7 +226884,7 @@ spec: | |||
| - YJt9t | |||
| ip: UYcKtV | |||
| - ip: 4uIxYAS | |||
| - {} | |||
| - ip: "" | |||
There was a problem hiding this comment.
This feels a bit suspect. Any idea where this change is coming from?
There was a problem hiding this comment.
I have no idea. I believe some of the changes in transpiler due to the fact we have multiple go modules.
There was a problem hiding this comment.
Figured this out in another PR of mine! It comes from updating the Kubernetes SDK. I think the IP field changed from *string to string.
| @@ -39,3 +39,11 @@ dist/ | |||
|
|
|||
| # Ignore depedencies | |||
| charts/*/charts/*.tgz | |||
|
|
|||
| # Ignore gotestsum junit reports | |||
There was a problem hiding this comment.
Could we instead have this output to a single well known place? If we consolidated the test task (or perhaps we should have a ci:test task in this case) we could output this file to the root of the repo or else where instead of having to micromanage these ignores.
There was a problem hiding this comment.
My initial plan was to use that, but then it's much easier to create buildkite matrix to test individual package and see where the failure is. Even re-try is much easier as you will not re-run the world (we don't have go test cache). It would be only that particular package.
RafalKorepta
force-pushed
the
rk/k8s-464/re-run-gotohelm-and-others
branch
14 times, most recently
from
3f41889 to
7fc859f
Compare
RafalKorepta
force-pushed
the
rk/k8s-464/re-run-gotohelm-and-others
branch
2 times, most recently
from
575af04 to
05b2620
Compare
Within this change release process for operator does not change, but the operator unit tests will be run only in main and PRs. The linux limits are increased as the instability of operator unit tests might be caused by tests hitting those limitis.
In latest rpadmin the go routine leak was fixed. redpanda-data/common-go#43
RafalKorepta
force-pushed
the
rk/k8s-464/re-run-gotohelm-and-others
branch
from
05b2620 to
7b49eb0
Compare
| @@ -7,6 +7,8 @@ | |||
| // the Business Source License, use of this software will be governed | |||
| // by the Apache License, Version 2.0 | |||
|
|
|||
| //go:build integration | |||
There was a problem hiding this comment.
I don't think we want to add build tags to all these tests. Doing so messes with diagnostic tools and can hide build failures. Instead there's a single file in my PR with helpers that toggles a boolean but otherwise doesn't mess with the build.
| @@ -226884,7 +226884,7 @@ spec: | |||
| - YJt9t | |||
| ip: UYcKtV | |||
| - ip: 4uIxYAS | |||
| - {} | |||
| - ip: "" | |||
There was a problem hiding this comment.
Figured this out in another PR of mine! It comes from updating the Kubernetes SDK. I think the IP field changed from *string to string.
| @@ -62,6 +64,9 @@ | |||
| pkgs.kustomize | |||
| pkgs.kuttl | |||
| pkgs.openssl | |||
| pkgs.helm-docs | |||
| pkgs.helm-3-10-3 | |||
| pkgs.go-junit-report | |||
There was a problem hiding this comment.
suuuuuuuuuuper nit: please sort this alphabetically :D
| @@ -384,12 +387,15 @@ func FindAllNames(pkg *types.Package, root types.Type) []*types.Named { | |||
| push(current.Underlying()) | |||
|
|
|||
| switch current := current.(type) { | |||
| case *types.Basic, *types.Interface, *types.TypeParam: | |||
| case *types.Basic, *types.Interface, *types.TypeParam, *types.Alias: | |||
There was a problem hiding this comment.
types.Alias should be handled as the other types:
case *types.Alias:
push(current.RHS())
| // the Business Source License, use of this software will be governed | ||
| // by the Apache License, Version 2.0 | ||
|
|
||
| //go:build integration |
There was a problem hiding this comment.
Same note about the build tag here but we can handle that after merging this PR.
Based on #354
9735fd3
Add
go-tools,helm-docsandhelmcli to nix definition. Copy most of task file from helm-charts.1188a6e
Re-run helm-docs
85570bc
Add genpartial to go workspace.
885b0f5
Add
type.Aliasto genpartial as runninggenpartialshows that this type is unhandled and it panic.5af3ee8
Add
gotohelmto go workspace.b960e79
Add
genschemato go workspace.b9b7c4a
Re-run charts generators (
task charts:generate).d6ac7f5
Re-run
task charts:lint.K8S-464