operator v1: allow upscale while decom in progress #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birdayz
requested review from
RafalKorepta,
chrisseto and
andrewstucki
as code owners
|
@RafalKorepta can you please have a look ? this is ready for review. thanks! |
RafalKorepta
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the operator first checks if a decommission is in progress, and then skips the scaling handler.
This leads to upscaling being blocked, if a decommission is in progress. In some cases it still works, if the nodepool that wants to upscale gets called first, before the other nodepool that should start scaling down. I wouldn't call it a race condition, but definitely flawed logic.
This PR updates scale handler control flow, so it first considers scaling up, before rejecting scale-down because of in-progress decommission on a different node pool.