default chartVersion: "" to go redpanda's version
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
force-pushed
the
chris/p/pin-chart-ref
branch
2 times, most recently
from
b9c9da8 to
4b539b6
Compare
Prior to this commit `chartVersion` would default to the latest version of the redpanda chart available at the time the helm repository controller ran. This ended up being more confusing and possibly dangerous than it did being convenient. Our documentation has begun telling users to explicitly pin `chartVersion` themselves for stability. Additionally, such functionality complicated the incipient de-fluxing migration. To resolve the above, this commit has changed the behavior to instead default `chartVersion` to the version of the redpanda chart that's installed via the `go.mod` file. At the time of this commit, that version is 5.9.9.
RafalKorepta
approved these changes
Oct 28, 2024
|
Tests found one missing CRD @andrewstucki was quicker :) |
Comment on lines
20
to
33
| names := map[string]struct{}{ | ||
| "buckets.source.toolkit.fluxcd.io": {}, | ||
| "clusters.redpanda.vectorized.io": {}, | ||
| "consoles.redpanda.vectorized.io": {}, | ||
| "gitrepositories.source.toolkit.fluxcd.io": {}, | ||
| "helmcharts.source.toolkit.fluxcd.io": {}, | ||
| "helmreleases.helm.toolkit.fluxcd.io": {}, | ||
| "helmrepositories.source.toolkit.fluxcd.io": {}, | ||
| "ocirepositories.source.toolkit.fluxcd.io": {}, | ||
| "redpandas.cluster.redpanda.com": {}, | ||
| "topics.cluster.redpanda.com": {}, | ||
| "users.cluster.redpanda.com": {}, | ||
| } |
There was a problem hiding this comment.
The schemas needs to be added.
https://github.com/redpanda-data/redpanda-operator/blob/main/operator/api/redpanda/v1alpha2/schema_types.go
#264
chrisseto
force-pushed
the
chris/p/pin-chart-ref
branch
from
4b539b6 to
14b4e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit
chartVersionwould default to the latest version of the redpanda chart available at the time the helm repository controller ran.This ended up being more confusing and possibly dangerous than it did being convenient. Our documentation has begun telling users to explicitly pin
chartVersionthemselves for stability.Additionally, such functionality complicated the incipient de-fluxing migration.
To resolve the above, this commit has changed the behavior to instead default
chartVersionto the version of the redpanda chart that's installed via thego.modfile. At the time of this commit, that version is 5.9.9.