support https configuration #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weeco can you please review |
weeco
reviewed
Nov 3, 2024
Comment on lines
+7
to
+8
| TLSCertFile string `koanf:"tlsCertificate"` | ||
| TLSKeyFile string `koanf:"tlsKey"` |
There was a problem hiding this comment.
I tried to update this into your branch, but I didn't have permissions to do changes. A minor change for consistency with other TLS configs (kafka.tls)
Suggested change
| TLSCertFile string `koanf:"tlsCertificate"` | |
| TLSKeyFile string `koanf:"tlsKey"` | |
| TLSCertFile string `koanf:"tlsCertFilepath"` | |
| TLSKeyFile string `koanf:"tlsKeyFilepath"` |
Comment on lines
+175
to
+178
| # Certificate file to be used if configuring as a HTTPS server, leave empty to configure as a HTTP server | ||
| tlsCertificate: "" | ||
| # Key file to be used if configuring as a HTTPS server, ignored if tlsCertificate isnt set | ||
| tlsKey: "" |
There was a problem hiding this comment.
Suggested change
| # Certificate file to be used if configuring as a HTTPS server, leave empty to configure as a HTTP server | |
| tlsCertificate: "" | |
| # Key file to be used if configuring as a HTTPS server, ignored if tlsCertificate isnt set | |
| tlsKey: "" | |
| # Certificate file to be used if configuring as an HTTPS server, leave empty to configure as an HTTP server | |
| tlsCertFilepath: "" | |
| # Key file to be used if configuring as a HTTPS server, ignored if tlsCertFilepath isn't set | |
| tlsKeyFilepath: "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.