Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc-752 Update FIPS to add tabs with one for RHEL and one for Debian/Ubuntu #914

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Feediver1
Copy link
Contributor

@Feediver1 Feediver1 commented Dec 11, 2024

Description

Resolves https://redpandadata.atlassian.net/browse/DOC-752
Review deadline: Dec 11

Page previews

Preview

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Feediver1 Feediver1 requested a review from a team as a code owner December 11, 2024 02:13
Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit a640eea
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6759d7f9dc4ea30008cd1332
😎 Deploy Preview https://deploy-preview-914--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@KavyaShivashankar KavyaShivashankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RHEL package manager is YUM. the command for RHEL should change to sudo yum install instead of sudo apt install

Also the command needs to include repdanda-fips package
sudo yum install -y repdanda-fips redpanda-rpk-fips

@Deflaimun
Copy link
Contributor

This PR could also include this issue
https://redpandadata.atlassian.net/browse/DOC-859

@@ -29,9 +34,32 @@ NOTE: Alternatively, you could run `sudo apt install -y redpanda-fips`, which al

If you wish to only use `rpk` on a FIPS host, run:

[,bash]
----
sudo yum install -y repdanda-fips redpanda-rpk-fips
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo yum install -y repdanda-fips redpanda-rpk-fips
sudo yum install repdanda-fips redpanda-rpk-fips

We should remove the -y as it accepts all prompts. User most knowingly accept them before continuing.


[,bash]
----
sudo apt install -y redpanda-rpk-fips redpanda-fips
Copy link
Contributor

@Deflaimun Deflaimun Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo apt install -y redpanda-rpk-fips redpanda-fips
sudo apt install redpanda-rpk-fips redpanda-fips

We should remove the -y as it accepts all prompts. User most knowingly accept them before continuing.

sudo apt install -y redpanda-rpk-fips redpanda-fips
----

NOTE: Alternatively, you could run `sudo install -y redpanda-fips`, which also picks up and includes the `redpanda` install package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: Alternatively, you could run `sudo install -y redpanda-fips`, which also picks up and includes the `redpanda` install package.
NOTE: Alternatively, you could run `sudo install redpanda-fips`, which also picks up and includes the `redpanda` install package.

Copy link
Contributor

@Deflaimun Deflaimun Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no package manager here? check if the tip should be sudo apt install redpanda-fips

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command should be sudo apt install redpanda-fips for Debian/Ubuntu and sudo yum install redpanda-fips for Rhel

Copy link
Contributor

@Deflaimun Deflaimun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check suggestions

@Deflaimun
Copy link
Contributor

sudo apt install -y redpanda-rpk-fips redpanda-fips

this line should be changed to yum too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants