-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc-752 Update FIPS to add tabs with one for RHEL and one for Debian/Ubuntu #914
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RHEL package manager is YUM. the command for RHEL should change to sudo yum install instead of sudo apt install
Also the command needs to include repdanda-fips package
sudo yum install -y repdanda-fips redpanda-rpk-fips
This PR could also include this issue |
@@ -29,9 +34,32 @@ NOTE: Alternatively, you could run `sudo apt install -y redpanda-fips`, which al | |||
|
|||
If you wish to only use `rpk` on a FIPS host, run: | |||
|
|||
[,bash] | |||
---- | |||
sudo yum install -y repdanda-fips redpanda-rpk-fips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sudo yum install -y repdanda-fips redpanda-rpk-fips | |
sudo yum install repdanda-fips redpanda-rpk-fips |
We should remove the -y
as it accepts all prompts. User most knowingly accept them before continuing.
|
||
[,bash] | ||
---- | ||
sudo apt install -y redpanda-rpk-fips redpanda-fips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sudo apt install -y redpanda-rpk-fips redpanda-fips | |
sudo apt install redpanda-rpk-fips redpanda-fips |
We should remove the -y
as it accepts all prompts. User most knowingly accept them before continuing.
sudo apt install -y redpanda-rpk-fips redpanda-fips | ||
---- | ||
|
||
NOTE: Alternatively, you could run `sudo install -y redpanda-fips`, which also picks up and includes the `redpanda` install package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: Alternatively, you could run `sudo install -y redpanda-fips`, which also picks up and includes the `redpanda` install package. | |
NOTE: Alternatively, you could run `sudo install redpanda-fips`, which also picks up and includes the `redpanda` install package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no package manager here? check if the tip should be sudo apt install redpanda-fips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command should be sudo apt install redpanda-fips for Debian/Ubuntu and sudo yum install redpanda-fips for Rhel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check suggestions
this line should be changed to |
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-752
Review deadline: Dec 11
Page previews
Preview
Checks