plugin upload release workflow - fix dry-run determination #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackietung-redpanda
force-pushed
the
jackie-plugin-yaml-bool
branch
from
9886ff8 to
60d05e2
Compare
|
Tested manually:
Build error shown as headline is only because I cancelled the full release build (docker, goreleaser jobs) from the dummy RC tag test. |
ivotron
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was that DRY_RUN always evaluated to true, due to misunderstanding about GHA expressions syntax and how that can be used as env vars under different contexts. At least this is probably the least bad way to fail.
We fix it all up here.