Add QuestDB Output Component #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is cool |
rockwotj
reviewed
Sep 3, 2024
internal/impl/questdb/output.go
Outdated
Comment on lines
53
to
62
| service.NewBoolField("tlsEnabled"). | ||
| Description("Use TLS to secure the connection to the server"). | ||
| Optional(), | ||
| service.NewStringField("tlsVerify"). | ||
| Description("Whether to verify the server's certificate. This should only be used for testing as a "+ | ||
| "last resort and never used in production as it makes the connection vulnerable to "+ | ||
| "man-in-the-middle attacks. Options are 'on' or 'unsafe_off'."). | ||
| Optional(). | ||
| Default("on"). | ||
| LintRule(`root = if ["on","unsafe_off"].contains(this != true { ["valid options are \"on\" or \"unsafe_off\"" ] }`), |
There was a problem hiding this comment.
We have a service.NewTLSToggledField("tls") that has default fields supported everywhere - can we please us that?
There was a problem hiding this comment.
Yep, how's this? Our sender uses the tlsConfig contained in the unmarshalled conf.
rockwotj
approved these changes
Sep 9, 2024
| } | ||
|
|
||
| // Apply pool-level options | ||
| // todo: is this the correct interpretation of max-in-flight? |
There was a problem hiding this comment.
Max in flight is how many messages that connect will call concurrently with WriteBatch. So you probably want the same amount of senders as WriteBatch can be called concurrently, I think this makes sense.
| return err | ||
| }) | ||
|
|
||
| // This will flush the sender, no need to call sender.Flush at the end of the method |
There was a problem hiding this comment.
Maybe also mention this will flush and put back in the pool?
// This will flush the sender. If the flush was successful the sender is also put back in the pool.
Jeffail
force-pushed
the
add-questdb-component
branch
from
0862ada to
649e602
Compare
|
LGTM, thanks @sklarsa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an output component for writing to QuestDB tables using ILP (Influx Line Protocol) as implemented by the official QuestDB Go Client.