Skip to content

Commit

Permalink
don't upload plugin flow on forks, polish lint job
Browse files Browse the repository at this point in the history
  • Loading branch information
jackietung-redpanda committed Sep 4, 2024
1 parent 4193ea8 commit 769599a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/test_plugin_uploader.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,11 @@ jobs:
with:
python-version: '3.12'

- uses: chartboost/ruff-action@v1
with:
version: 0.4.10
src: './resources/plugin_uploader'
- name: Lint with Ruff
working-directory: resources/plugin_uploader
run: |
pip install ruff==0.4.10
ruff check --output-format=github
pyright-type-check:
runs-on: ubuntu-latest
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/upload_plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
upload_rpk_connect_plugin:
# Let's make this fast by using a beefy runner.
runs-on: ubuntu-latest-32
if: ${{ github.repository == 'redpanda-data/connect' }}
permissions:
contents: read
id-token: write
Expand All @@ -43,11 +44,9 @@ jobs:
,sdlc/prod/github/rpk_plugin_publisher
parse-json-secrets: true

- name: Check out code repo
uses: actions/checkout@v4
- uses: actions/checkout@v4

- name: Install Go
uses: actions/setup-go@v5
- uses: actions/setup-go@v5
with:
go-version: 1.22.x
check-latest: true
Expand Down

0 comments on commit 769599a

Please sign in to comment.