Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpadmin: expose rack,host,port,uuid info via api_broker #27

Merged
merged 1 commit into from
Sep 28, 2024
Merged

rpadmin: expose rack,host,port,uuid info via api_broker #27

merged 1 commit into from
Sep 28, 2024

Conversation

daisukebe
Copy link
Contributor

This commit adds additional field to the Broker
struct in api_broker.go. This will be used in
'rpk redpanda admin brokers list' to print those
info additionally.

@daisukebe daisukebe requested a review from r-vasquez September 25, 2024 04:42
@daisukebe
Copy link
Contributor Author

Context:

Currently the only way to map node ID to host address is rpk cluster status -b which calls the Kafka API. However, when a node is down it is not listed in the output, thus they're invisible. rpk redpanda admin brokers list uses the admin API and always lists all nodes in the cluster, no matter a node is up or down.

Given that, I'd like to have the host info included in the list command.

@daisukebe
Copy link
Contributor Author

Hold on. I'd like to add additional info, /v1/broker_uuids.

@daisukebe daisukebe force-pushed the main branch 2 times, most recently from 3130a63 to 939af42 Compare September 26, 2024 00:53
@daisukebe
Copy link
Contributor Author

It's ready for review @r-vasquez. Thank you!

@daisukebe daisukebe changed the title rpadmin: add rack,host,port info to api_broker rpadmin: add rack,host,port,uuid info to api_broker Sep 26, 2024
@daisukebe daisukebe changed the title rpadmin: add rack,host,port,uuid info to api_broker rpadmin: expose rack,host,port,uuid info via api_broker Sep 27, 2024
r-vasquez
r-vasquez reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 minor naming comments.

rpadmin/api_broker.go Outdated Show resolved Hide resolved
rpadmin/api_broker.go Outdated Show resolved Hide resolved
@daisukebe
rpadmin: expose rack,host,port,uuid info via api_broker
8913bb6 
This commit adds additional fields to the Broker
struct in api_broker.go. This will be used in
'rpk redpanda admin brokers list' to print those
info additionally.
@daisukebe daisukebe requested a review from r-vasquez September 28, 2024 12:19
r-vasquez
r-vasquez approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@daisukebe daisukebe merged commit b44fa6a into redpanda-data:main Sep 28, 2024
2 checks passed
@daisukebe
Copy link
Contributor Author

Tagged as https://github.com/redpanda-data/common-go/tree/rpadmin/v0.1.7

@daisukebe daisukebe mentioned this pull request Oct 2, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daisukebe @r-vasquez