Repository navigation
test(cli): carry ZIP module-archive contract tests forward from #1256 - #1292
Merged
Merged
Conversation
#1265 took only the Rustls lockfile patch from #1245's branch, which left #1256's ZIP 9 contract suite and module-archive docs stranded there. The nine tests check inspect's JSON contract, UTF-8 and CP437 name decoding, CRC and invalid-archive failures, and that inspect never extracts. They pass unchanged against zip 9.0.5. Also fixes the last serde_yaml reference in the developer docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1265 took only the Rustls lockfile patch from #1245's branch, so the ZIP 9 work from #1256 that doesn't depend on the YAML backend was left behind there. This carries it forward before #1245 is closed:
crates/redisctl/tests/module_archive_contracts.rs: nine offline contract tests forenterprise module packageandinspect. They check inspect's JSON output (so_file,valid,has_subdirectories), UTF-8 and CP437 name decoding, the corrupt-CRC and invalid-archive failures, metadata validation before packaging, and that inspect never extracts. The file is copied unchanged from 3739629.docs/docs/enterprise/commands/index.md: the "Module archives" section from build(deps): replace the unmaintained YAML backend #1256, which documents the ZIP 6 to 9 filename-decoding change. Also copied unchanged.docs/docs/developer/architecture.md: the lastserde_yamlreference in the tree, nowserde_norway.There are no source changes. These tests are the only coverage of the zstd 0.14 and lzma-rust2 0.22 codec bumps that came with zip 9, and of the accepted name-decoding behavior.
Testing
On the branch, rebased onto main at e74cae0:
cargo fmt --all -- --check: clean.cargo clippy -p redisctl --all-features --tests -- -D warnings: clean. The full--all-targets --all-featuresrun was also clean before the rebase.cargo test -p redisctl --all-features --test module_archive_contracts: 9 passed.