Hitless-Upgrade: Add handling of MOVING push notification with "null" host:port info. #3738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests for maintenance_events.py file
…tion pool - this should be a separate PR
… Refactored the maintenance events tests not to be multithreaded - we don't need it for those tests.
…ot processed in in Moving state. Tests are updated
…ply them during connect
Signed-off-by: Elena Kolevska <[email protected]> Cleanup Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
…isting ones more generic
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
…actConnection class
…e better retry_on_error handling on connection initialization.
petyaslavova
force-pushed
the
ps_add_fail_over_events_handling
branch
from
8d7cc00 to
10ded34
Compare
Base automatically changed from
ps_add_fail_over_events_handling
to
feat/hitless-upgrade-sync-standalone
August 19, 2025 09:08
…o connection moving info to be able to handle properly connections on Moved.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling MOVING push notifications that contain "null" host:port information, which occurs when Redis doesn't provide specific node address details during cluster maintenance operations.
Key Changes
- Modified
NodeMovingEventto acceptNonevalues for host and port parameters - Updated parser logic to handle "null" values in MOVING push notifications
- Enhanced maintenance event handling to process events without specific destination addresses
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
redis/maintenance_events.py |
Updated NodeMovingEvent constructor to accept optional host/port and modified hash calculation |
redis/_parsers/base.py |
Added parsing logic to handle "null" host:port values in MOVING notifications |
redis/connection.py |
Enhanced connection pool methods to support event hash tracking and conditional host updates |
tests/test_maintenance_events.py |
Added test cases for events with None host/port values |
tests/test_maintenance_events_handling.py |
Added comprehensive integration test for null MOVING events and updated existing tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.