Skip to content

[Async] Multi Exec on cluster #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vladvildanov
Copy link
Collaborator

@vladvildanov vladvildanov commented May 19, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Async implementation of #3611

except Exception as e:
error = e

thread = threading.Thread(target=runner)
Copy link
Collaborator Author

@vladvildanov vladvildanov May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petyaslavova @elena-kolevska ClusterPipeline provides only synchronous API for execute_command method, so because of this limitation the only way I found to run asynchronous code inside of synchronous method is to run it inside of short-living thread with it's own event loop. During testing I didn't find a significant performance impact of this (basic set/get test takes around 15ms on my machine).

I think the reason why API is synchronous is the fact that in case of Pipeline execute_command is just about adding command into queue, but for Transactions we need much more that requires asynchronous code execution. Let me know WDYT about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant