Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Harden the replicas check #3523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

apolukhin
Copy link

@apolukhin apolukhin commented Feb 21, 2025

Harden the checks

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

On MacOS the get_replicas() call returns empty list, even though the cluster_nodes() returns primaries and replicas and RedisCluster was created after the replicas negotiated with masters. This PR attempts to harden the checks, to make sure that replicas exist.

harden the checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant