-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PEP 517 packaging using hatchling #2930
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2930 +/- ##
==========================================
- Coverage 91.84% 91.84% -0.01%
==========================================
Files 128 127 -1
Lines 33232 33270 +38
==========================================
+ Hits 30523 30557 +34
- Misses 2709 2713 +4 ☔ View full report in Codecov by Sentry. |
Rebased. |
7c9926b
to
4dbdd76
Compare
Rebased. Cc @gerzse @vladvildanov. |
@akx Thanks for your contribution! I'll review this PR in near time |
@vladvildanov Good to hear. Rebased once again. |
cc362bc
to
ac7e7e7
Compare
b0fe33b
to
697c349
Compare
Refs redis#1316 Refs redis#1649 Remake of redis#2388 Co-authored-by: Ofek Lev <[email protected]>
@vladvildanov Rebased. I'll fix the tests if there's any interest in this. |
Could you add "closes #3463 "? |
Btw: the tests failing in
is very curious – given the string "5.3.0b5" does not appear in the source here at all, it almost looks like the CI pipeline is installing an entirely different version of the package... and indeed:
IOW, the CI pipeline seems to be confused about which libraries it's using... |
c19d8a4
to
026dbe1
Compare
Pull Request check-list
Please make sure to review and check all of these items:
Description of change
*❗Contains dependency changes from Partial clean up of Python 3.7 compatibility #2928
Quoting the description from #2388, a year later...
This PR shifts redis-py from legacy
setup.py
packaging to PEP 517 compliant packaging usinghatchling
from PyPA.Essentially, this does what was discussed in #1658 but with the increasingly standard
hatchling
tool instead of poetry's idiosyncracies.As with #2388,
python -m build
does create a working wheel with all modules included.