Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent negative TTLs from insta-killing @Document annotated ent… #430

Merged
merged 1 commit into from
May 14, 2024
Merged

fix: prevent negative TTLs from insta-killing @Document annotated ent… #430

merged 1 commit into from
May 14, 2024

Conversation

bsbodden
Copy link
Contributor

…ities with save/saveAll (resolves gh-429)

@bsbodden bsbodden requested review from slorello89 and guyroyse May 10, 2024 23:31
guyroyse
guyroyse approved these changes May 14, 2024
View reviewed changes
Copy link

@guyroyse guyroyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy. Ship it!

@bsbodden bsbodden merged commit 221ffdf into redis:main May 14, 2024
4 checks passed
@bsbodden bsbodden deleted the bsb/fix-negative-ttl-in-document-entities-gh429 branch May 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyroyse guyroyse guyroyse approved these changes

@slorello89 slorello89 Awaiting requested review from slorello89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative @TimeToLive value in @Document entity executes redis EXPIRE command
2 participants
@bsbodden @guyroyse