fix: QueryUtils#escape should handle nulls (resolves gh-452)

redis · Jun 5, 2024 · 356bef3 · 356bef3
1 parent 09fdb2b
commit 356bef3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/redis-om-spring/src/main/java/com/redis/om/spring/repository/query/QueryUtils.java b/redis-om-spring/src/main/java/com/redis/om/spring/repository/query/QueryUtils.java
@@ -19,6 +19,9 @@ public static String escape(String text) {
   }
 
   public static String escape(String text, boolean querying) {
+    if (text == null) {
+      return null;
+    }
     var sb = new StringBuilder();
     char[] chars = text.toCharArray();
 

diff --git a/redis-om-spring/src/test/java/com/redis/om/spring/repository/query/QueryUtilsTest.java b/redis-om-spring/src/test/java/com/redis/om/spring/repository/query/QueryUtilsTest.java
@@ -30,4 +30,14 @@ void testSearchIndexFieldAlliasFor() {
     assertEquals(field.getName(), outputWhenPrefixBlank);
     assertEquals("roger_green_redis", outputWhenPrefixValid);
   }
+
+  @Test
+  void testEscapeWithNullValue() {
+    assertEquals(null, QueryUtils.escape(null));
+  }
+
+  @Test
+  void testEscapeWithBlankValue() {
+    assertEquals("", QueryUtils.escape(""));
+  }
 }