Skip to content

Topologies #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

Topologies #319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c4c51b
create a unique filename for different topologies instead of always h…
slice4e Oct 15, 2025
8e21f5b
adding topology info to aggregate results as well
slice4e Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions redis_benchmarks_specification/__runner__/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,7 +1686,7 @@ def delete_temporary_files(
logging.info(
f"Connected to Redis using individual parameters: {host}:{port}"
)
setup_name = "oss-standalone"
setup_name = topology_spec_name
r.ping()

# Auto-detect server information if not explicitly provided
Expand Down Expand Up @@ -2440,7 +2440,7 @@ def delete_temporary_files(
start_time_str,
git_hash,
test_name,
setup_type,
setup_name,
)
logging.info(
"Will store benchmark json output to local file {}".format(
Expand Down Expand Up @@ -2872,6 +2872,7 @@ def delete_temporary_files(
test_name,
results_matrix,
redis_conns,
setup_name,
)
else:
# Single client - read from file as usual
Expand Down Expand Up @@ -2950,6 +2951,7 @@ def delete_temporary_files(
test_name,
results_matrix,
redis_conns,
setup_name,
)

dataset_load_duration_seconds = 0
Expand Down Expand Up @@ -3525,6 +3527,7 @@ def prepare_overall_total_test_results(
test_name,
overall_results_matrix,
redis_conns=None,
topology=None,
):
# check which metrics to extract
(
Expand Down Expand Up @@ -3560,8 +3563,13 @@ def get_overall_display_name(x):

return x[0] # Use original path

# Include topology in the test name if provided
test_name_with_topology = test_name
if topology:
test_name_with_topology = f"{topology}-{test_name}"

current_test_results_matrix = [
[test_name, get_overall_display_name(x), f"{x[3]:.3f}"]
[test_name_with_topology, get_overall_display_name(x), f"{x[3]:.3f}"]
for x in current_test_results_matrix
]
overall_results_matrix.extend(current_test_results_matrix)
Expand Down
Loading