ci(release-rpm): accept NOKEY in verify (signing step is source of truth) (2.3)#373
Merged
fcostaoliveira merged 1 commit intoredis:2.3from May 6, 2026
Conversation
fcostaoliveira
force-pushed
the
fix/release-rpm-accept-nokey-2.3
branch
from
c8ab08f to
3b747fa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 3b747fa. Configure here.
…uth) The publish-to-yum verify step has now hard-failed twice on the 2.3.1 release because `rpm -Kv` reports NOKEY (the public key for the V4 signing subkey is not in the runner's rpm keyring after the `gpg --export | rpm --import` round-trip). The packages are correctly V4-signed — the failure is a key-management glitch in the verify step, not a packaging defect. The signing step (`rpm --addsign $rpm_file` with $SIGN_FPR pulled from $APT_SIGNING_KEY) is the source of truth for "is signed" — its non-zero exit fails the workflow before verify runs. Treat NOKEY here as a warning rather than a hard error so the publish path isn't blocked by a fragile keyring round-trip. Still hard-fail on: - missing V3/V4 signature header (signing didn't happen) - BAD (corrupted/tampered signature) Refs: 2.3.1 publish-to-yum runs 25388333208 and 25435030368. Follow-up: debug the gpg→rpm subkey import so the `OK` path is reachable in CI; the relaxation here is a workaround for the immediate backfill, not a permanent state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fcostaoliveira
force-pushed
the
fix/release-rpm-accept-nokey-2.3
branch
from
3b747fa to
1d70aab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #372 to the
2.3release branch.The 2.3.1
publish-to-yumstep has now hard-failed twice onHeader V4 RSA/SHA512 Signature, key ID bf53aa0c: NOKEY. The packages are correctly V4-signed;NOKEYis a key-management glitch in the gpg→rpm round-trip on a fresh CI runner, not a packaging defect. The signing step (rpm --addsign) is the source of truth for "is signed".Treat verify as a guard against silent regressions:
BAD(corrupted/tampered)NOKEY(signed but key not in CI keyring)Once this lands, retag
2.3.1to the new 2.3 tip, delete+recreate the release, andpublish-to-yumshould reach S3 for the first time on this release.🤖 Generated with Claude Code
Note
Medium Risk
Changes release CI signature verification logic for RPM publishing; a regex/logic mistake could allow unsigned or corrupted RPMs to be published or block valid releases.
Overview
Updates the
release-rpm.ymlRPM verification step to stop failing releases onNOKEYresults fromrpm -Kvwhen a V3/V4 signature header is present.Verification now hard-fails on
BAD/NOTTRUSTEDanywhere and on missing V3/V4 signature headers (signing didn’t happen), while emitting a warning if the signature line reportsNOKEY(key not in the CI RPM keyring) and continuing the publish.Reviewed by Cursor Bugbot for commit 1d70aab. Bugbot is set up for automated code reviews on this repo. Configure here.