Add LREM command support for removing list elements by value #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishanthp
changed the title
Author
|
I was not sure how to add reviewers, so tagging you to review the PR mortensi. Thank you! |
Member
|
Thanks @nishanthp, we are looking at restructuring the toolset, and eventually reduce the number of exposed tools. As soon as we move forward, we'll review the PR and work on it. Thanks for contributing, I will keep you posted! |
Author
|
Thanks @mortensi for the update! Looking forward to collaborating with you as things progress. |
vchomakov
reviewed
Nov 6, 2025
Comment on lines
+78
to
+99
| async def lrem(name: str, count: int, element: FieldT) -> str: | ||
| """Remove elements from a Redis list. | ||
| Args: | ||
| name: The name of the list | ||
| count: Number of elements to remove (0 = all, positive = from head, negative = from tail) | ||
| element: The element value to remove | ||
| Returns: | ||
| A string indicating the number of elements removed. | ||
| """ | ||
| try: | ||
| r = RedisConnectionManager.get_connection() | ||
| removed_count = r.lrem(name, count, element) | ||
|
|
||
| if removed_count == 0: | ||
| return f"Element '{element}' not found in list '{name}' or list does not exist." | ||
| else: | ||
| return f"Removed {removed_count} occurrence(s) of '{element}' from list '{name}'." | ||
|
|
||
| except RedisError as e: | ||
| return f"Error removing element from list '{name}': {str(e)}" |
Member
There was a problem hiding this comment.
This tool needs to be covered by unit tests (see test_list.py) for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the LREM (List Remove) functionality in list.py, enabling removal of list elements by value with count-based control.
Changes:
lremfunction to support Redis LREM commandcount > 0: Remove elements from head to tailcount < 0: Remove elements from tail to headcount = 0: Remove all matching elementsUsage: