Reduce CPU cycles spent on setting tracing tags #3339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.Addresses #3308 to avoid creating a
RedisURI
object when setting tracing tags. As explained in the issue, the current behavior results in unnecessary CPU usage.This change caches the necessary information that is added to span tags each time the channel is registered.
This should work as long as the RedisUri attribute attached to the channel doesn't change (is that a correct assumption?).
The alternative is to just extract the information each time from
channel.attr(ConnectionBuilder.REDIS_URI).get()
. Something like: