Deprecate DnsResolver in favor of AddressResolverGroup(#1572) #3291
+30
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mvn formatter:format
target. Don’t submit any formatting related changes.Summary
This PR deprecates Lettuce's internal DNS resolver and removes the conditional logic that checks for the presence of Netty's DNS resolver on the classpath.
Closes #1527
Background
Until Lettuce 6.1, 'netty-resolvers-dns' was treated as an optional dependency and used conditionally if present on the classpath. However [issue #1527] and previous discussions(e.g., #1517) suggest that 'netty-resolver-dns' should become a required dependency starting from version 6.2.
When reviewing the latest codebase (currently 6.6), I found that:
Based on this history, I've made the following changes:
Changes
Let me know if additional coverage or documentation is needed.
Thanks!!