RC: Redis hashing policy #1139
Open
RC: Redis hashing policy #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmilesb
commented
Feb 11, 2025
yoavredis
reviewed
Feb 18, 2025
yoavredis
reviewed
Feb 18, 2025
yoavredis
reviewed
Feb 18, 2025
| (FLUSHDB) before they're applied. | ||
|
|
||
| These changes include: | ||
|
|
||
| 1. Changing the hashing policy, either from standard to custom or vice versa. |
There was a problem hiding this comment.
Following the previous comment, maybe we should keep the original line ("either from...").
"Changing the hashing policy" implies that all policies could be changed, which is not the case with the "Redis" option.
yoavredis
reviewed
Feb 18, 2025
cmilesb
commented
Feb 18, 2025
cmilesb
commented
Feb 18, 2025
yoavredis
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
@cmilesb LGTM, 10x.
@joniredis please review and approve, especially the "For accounts created after MONTH DAY, 2025," statements.
andy-stark-redis
approved these changes
Feb 21, 2025
content/operate/rc/databases/create-database/create-pro-database-new.md
Outdated
Show resolved
Hide resolved
Co-authored-by: andy-stark-redis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing mid-march. Need to change changelog