RI-7214: Replace EUI loading logo with custom bouncing logo component #4768
+60
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantovska
requested review from
KrumTy,
pawelangelow,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
Code Coverage - Frontend unit tests
Test suite run success4833 tests passing in 633 suites. Report generated by 🧪jest coverage report action from 4e2cfab |
dantovska
force-pushed
the
fe/feature/RI-7214-replace-eui-loading-logo
branch
from
3620a4e to
be56fce
Compare
valkirilov
previously approved these changes
Jul 29, 2025
pd-redis
reviewed
Jul 29, 2025
redisinsight/ui/src/components/base/display/logo-loading/RiLoadingLogo.tsx
Outdated
Show resolved
Hide resolved
dantovska
force-pushed
the
fe/feature/RI-7214-replace-eui-loading-logo
branch
from
be56fce to
e3c367f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dantovska
force-pushed
the
fe/feature/RI-7214-replace-eui-loading-logo
branch
from
d918c51 to
fd6feb7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dantovska
force-pushed
the
fe/feature/RI-7214-replace-eui-loading-logo
branch
from
fd6feb7 to
4e2cfab
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Elastic UI loading logo component with a custom bouncing logo implementation. The main goal is to create a custom loading animation that provides more control over the visual appearance and behavior.
Key changes:
- Created a new
RiLoadingLogocomponent with custom bounce animation - Replaced
EuiLoadingLogousage with the new custom component - Updated the logo import to use the SVG file directly instead of as a React component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| PagePlaceholder.tsx | Replaces EuiLoadingLogo with custom RiLoadingLogo component |
| RiLoadingLogo.tsx | Implements new custom bouncing logo component with styled-components |
| index.ts | Exports the new RiLoadingLogo component |
redisinsight/ui/src/components/base/display/loading-logo/RiLoadingLogo.tsx
Show resolved
Hide resolved
redisinsight/ui/src/components/base/display/loading-logo/RiLoadingLogo.tsx
Show resolved
Hide resolved
redisinsight/ui/src/components/base/display/loading-logo/RiLoadingLogo.tsx
Show resolved
Hide resolved
pd-redis
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing, bouncy logo, only missing the shadow in the new implementation