Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds content filtering notebook and corresponding dataset #34

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

justin-cechmanek
Copy link
Contributor

No description provided.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome @justin-cechmanek my only feedback is to maybe do a little bit of explanation up front to help them get the gist of what a content filtering based recommendation system is? Also, might be good to highlight the schema used and walk folks through the design of that. Lastly, in the example at the end, if you can show what was used to query for recs, it might help contextualize the outputs a bit more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great feedback. I'll make these changes.

rbs333 added 2 commits October 8, 2024 16:44
Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple tweaks that I left comments for and changed "recommender-systems" to "recommendation-systems" since that's consistent with the readme and other places. Also add the new folder to tests.

rbs333 and others added 3 commits October 8, 2024 16:52
@justin-cechmanek justin-cechmanek merged commit f38bc79 into main Oct 9, 2024
1 check passed
@justin-cechmanek justin-cechmanek deleted the feat/RAAE-252/content-filtering branch December 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants