Add session manager recipe examples #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
changed the title
tylerhutcherson
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Looks good. Left one comment on naming here.
Additionally, visually I think it would help for both notebooks to use more H2 and H3 markdown headers in the flow of the example to highlight the point you are making at each. It's hard to distinguish between your notes and the STDOUT from the demo :)
I would also highlight the reason why you have the little Cohere Client class in order to help demonstrate the real flow
Last point, might consider wrapping the session manager into the cohere class so it's a bit cleaner, but then you might miss out on the teachability /explainability of the example you have now. Just something to think about!
justin-cechmanek
deleted the
feat/RAAE-69/session-manager-recipe-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.