Fix inconsistencies in the readme, add Gateway API HTTPRoute support - #546
Fix inconsistencies in the readme, add Gateway API HTTPRoute support#546nerothank wants to merge 10 commits into
Conversation
redimp
left a comment
There was a problem hiding this comment.
Hey @nerothank,
Thanks for the Helm chart improvements! These are genuinely useful additions and
cleanups. Nice work on:
- Gateway API
HTTPRoutesupport as a first-class alternative to Ingress,
including theNOTES.txtoutput for it persistence.existingClaimso users can bring their own PVC (plus the requirements note that PV provisioning isn't mandatory)ingress.annotations/httproute.annotations/persistence.annotationsandpodLabelsAdditionalfor customizing generated resources- The
values.yamlregrouping into logical sections and the README table now documenting the previously-missing options
I did find three template bugs that block rendering (I know the PR is still a draft/untested, flagging them so they're captured). I've left inline comments with suggested fixes on each.
Please review and fix what I've found. Make sure helm lint works. Looking
forward to merge this.
so similar options remain together
before, no rules at all were created, leaving a non-functional httproute on defaults
e509f06 to
d8b2cf1
Compare
|
Hi @redimp Thank you for your valuable insights. I fixed the issues you mentioned and performed first tests on my k3s cluster. I should be able to test in more detail this weekend. |
The current version of the helm chart provided by An Otter Wiki works well and provides most functionality that most users would require. For my specific use-case there are some things missing, that I would like to contribute. Apart from new functionality there are also some changes to the README that fix inconsistencies and missing information.
Proposed changes
New functionality
Fixes to the README
persistence.existingClaimthat was undocumented before, and add missing value table entryingress.annotationspersistence.annotationspersistence.subPathCommon
0.2.0due to the new functionality introduced.Tests
The chart has been successfully tested: