Remove unneeded package from dnf #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to RPOPC-608 |
dvalinrh
requested changes
Sep 16, 2025
pcp/pcp_commands.inc
Outdated
| @@ -55,8 +55,8 @@ setup_pcp() | |||
| # If pmlogger isn't present, install the PCP bits | |||
| pcp_present=$(which pmlogger) | |||
| if [[ $? -ne 0 ]]; then | |||
| dnf install -y dnf install -y --setopt=tsflags=nodocs \ | |||
| pcp-zeroconf pcp-pmda-openmetrics pcp-pmda-denki sysbench | |||
| dnf install -y --setopt=tsflags=nodocs \ | |||
dvalinrh
approved these changes
Sep 17, 2025
dvalinrh
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes an unneeded package from a dnf command in setup_pcp, which lives in EPEL and will cause the dnf install to fail
Before/After Comparison
Before: The unneeded, by-default-unobtainable package will break the dnf install
After: dnf doesn't look for a package it can't install and which we don't need
Clerical Stuff
This closes #89
Relates to JIRA: RPOPC-608