Fix flake8 errors #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natifridman
force-pushed
the
fix-flake8
branch
2 times, most recently
from
f1d9fd3 to
d4fd82d
Compare
natifridman
force-pushed
the
fix-flake8
branch
from
719fdce to
d2e38b9
Compare
src/vse_sync_pp/parsers/phc2sys.py
Outdated
| @staticmethod | ||
| def build_regexp(): | ||
| """Return a regular expression string for parsing phc2sys log file lines""" | ||
| return r'\s'.join(( | ||
| r'^phc2sys' + | ||
| r'\[([1-9][0-9]*\.[0-9]{3})\]:'+ # timestamp | ||
| r'^phc2sys' + # noqa: W504 |
There was a problem hiding this comment.
Instead of adding a noqa I'd move the +
There was a problem hiding this comment.
Fixed, added the opposite W503 to the ignored list
jnunyez
reviewed
Sep 19, 2023
jnunyez
approved these changes
Sep 19, 2023
natifridman
force-pushed
the
fix-flake8
branch
from
f3a8910 to
e745dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.