Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heatmap plot #39

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

natifridman
Copy link
Contributor

Add heatmap abstract class for creating plots

src/vse_sync_pp/heatmap.py Outdated Show resolved Hide resolved
src/vse_sync_pp/heatmap.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jnunyez jnunyez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions to make the class documentation more generic. The rest LGTM.

@natifridman natifridman requested a review from jnunyez September 21, 2023 07:04
Add heatmap abstract class for creating plots
@natifridman natifridman merged commit 0fd699d into redhat-partner-solutions:main Sep 21, 2023
2 checks passed
@natifridman natifridman deleted the heatmap branch September 21, 2023 09:02
@jnunyez
Copy link
Collaborator

jnunyez commented Sep 26, 2023

@spenced anything blocking us to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants