ensure per-check logger carries the check name throughout execution #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
from change #1196: |
|
/test 4.13-e2e 4.17-e2e |
|
/test 4.17-e2e |
acornett21
approved these changes
Sep 16, 2024
Signed-off-by: Jose R. Gonzalez <[email protected]>
komish
force-pushed
the
extend-contextual-logging
branch
from
4da61b7
to
1e79527
Compare
acornett21
approved these changes
Sep 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet, komish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
from change #1196: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing checks, the engine emits check names at the start and end of a check's execution, as well as with the result. We run synchronously, so for the most part, this isn't a problem, but I noticed while troubleshooting something else that logs emitted from the check itself (after pulling the logger from context) don't include the check's name, and it's a small amount of code to pass that context into the check and make the logs a bit more clear.
This PR derives a logger with the check's name as a value, stuffs that into a new context to pass to check functions, and then strips all the other locations that were manually adding the "check" key to the logger.