chore(ci): use branch specific operator version for e2e #2420
Conversation
|
/test |
|
@zdrapela: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-tests-operator-nightly |
|
/test e2e-tests |
|
/test e2e-tests-operator-nightly |
|
@zdrapela: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick main |
|
@zdrapela: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
.ibm/pipelines/jobs/operator.sh
Outdated
| @@ -10,7 +10,14 @@ install_rhdh_operator() { | |||
| rm -f /tmp/install-rhdh-catalog-source.sh | |||
| curl -L https://raw.githubusercontent.com/redhat-developer/rhdh-operator/refs/heads/main/.rhdh/scripts/install-rhdh-catalog-source.sh > /tmp/install-rhdh-catalog-source.sh | |||
There was a problem hiding this comment.
Wouldn't it make more sense to also download the script from the appropriate release branch?
There was a problem hiding this comment.
Yeah, that's true, I'm changing it to use the correct branch. Thanks
.ibm/pipelines/jobs/operator.sh
Outdated
| echo "Installing RHDH operator with '--next' flag" | ||
| bash -x /tmp/install-rhdh-catalog-source.sh --next --install-operator rhdh | ||
| else | ||
| local operator_version="${RELEASE_BRANCH_NAME#release-}" |
There was a problem hiding this comment.
@zdrapela condition not required, you may use TAG_NAME instead. for eg:
bash -x /tmp/install-rhdh-catalog-source.sh "--$TAG_NAME" --install-operator rhdh
There was a problem hiding this comment.
@subhashkhileri the $TAG_NAME is useful and I changed the script to use it, but we still need the condition. For example --1.5 is not a valid input parameter for the script. Has to be -v 1.5 instead. See https://github.com/redhat-developer/rhdh-operator/blob/f186141100530856541a30b6696314064428dda8/.rhdh/scripts/install-rhdh-catalog-source.sh#L62-L64
|
/unhold |
zdrapela
force-pushed
the
1.5-operator-version-based-on-branch-2
branch
from
df5bf8d to
1a14f9d
Compare
|
/test e2e-tests-operator-nightly |
|
@zdrapela: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@subhashkhileri PR is ready |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9fefb96
into
redhat-developer:release-1.5
|
@zdrapela: new pull request created: #2433 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Based on: https://github.com/redhat-developer/rhdh-operator/blob/f186141100530856541a30b6696314064428dda8/.rhdh/scripts/install-rhdh-catalog-source.sh#L62-L64
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer