-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e-test): [Test automation] Verify global floating action button , application provider and listener #2405
base: main
Are you sure you want to change the base?
Conversation
cc @teknaS47 , I couldn't add you as a reviewer |
The image is available at: |
The image is available at: |
e921f30
to
04aa9b4
Compare
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Some small suggestions:
e2e-tests/playwright/e2e/plugins/application-provider-listener.spec.ts
Outdated
Show resolved
Hide resolved
e2e-tests/playwright/e2e/plugins/application-provider-listener.spec.ts
Outdated
Show resolved
Hide resolved
.filter({ hasText: section }); | ||
|
||
const itemLocator = sectionLocator.locator(`li[class*="MuiListItem-root"]`); | ||
expect(await itemLocator.count()).toBeGreaterThanOrEqual(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified, and tested on a local cluster. It looks good to me.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: teknaS47 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f8f5b75
to
0730930
Compare
The image is available at: |
Description
Added e2e tests for the global floating action button
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
To run the e2e tests successfully in your local:
Add the changes in the file
[dynamic-global-floating-action-button-config.yaml](https://github.com/redhat-developer/rhdh/pull/2405/files#diff-c872edf0bcd722091622844223e3e136c04a3aee0212ee6a806473205604c071)
in your app-config
Start the app in one terminal
In another terminal, from
e2e-tests
path run->
yarn showcase global-floating-button.spec.ts
->
yarn showcase application-provider-listener.spec.ts