Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e-test): [Test automation] Verify global floating action button , application provider and listener #2405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

debsmita1
Copy link
Member

@debsmita1 debsmita1 commented Feb 18, 2025

Description

Added e2e tests for the global floating action button

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

To run the e2e tests successfully in your local:

Add the changes in the file [dynamic-global-floating-action-button-config.yaml](https://github.com/redhat-developer/rhdh/pull/2405/files#diff-c872edf0bcd722091622844223e3e136c04a3aee0212ee6a806473205604c071)
in your app-config

Start the app in one terminal

In another terminal, from e2e-tests path run
-> yarn showcase global-floating-button.spec.ts

-> yarn showcase application-provider-listener.spec.ts

Screenshot 2025-02-18 at 8 16 47 PM Screenshot 2025-02-18 at 10 36 08 PM

@debsmita1
Copy link
Member Author

cc @teknaS47 , I couldn't add you as a reviewer

@debsmita1 debsmita1 changed the title chore(e2e-test): [Test automation] Verify global floating action button chore(e2e-test): [Test automation] Verify global floating action button , application provider and listener Feb 18, 2025
Copy link
Contributor

Copy link
Contributor

@debsmita1 debsmita1 force-pushed the fab-e2e branch 2 times, most recently from e921f30 to 04aa9b4 Compare February 19, 2025 06:55
Copy link
Contributor

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Some small suggestions:

.filter({ hasText: section });

const itemLocator = sectionLocator.locator(`li[class*="MuiListItem-root"]`);
expect(await itemLocator.count()).toBeGreaterThanOrEqual(0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@teknaS47 teknaS47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, and tested on a local cluster. It looks good to me.

Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: teknaS47
Once this PR has been reviewed and has the lgtm label, please ask for approval from debsmita1. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants