chore(ci): build multiplatform next container image #2036
Conversation
|
The image is available at: |
|
Do we want PR builds on arm too, in case you're developing something locally on your arm64 mac? |
I'm working on that as well. I'll do it in a separate PR. e2e tests depend on those images, so I want to make sure that they are not delayed by arm image builds |
|
The image is available at: |
|
The image is available at: |
|
The image is available at: |
kadel
force-pushed
the
build-multiplatform-next-image
branch
from
5d6bfc1 to
fbed803
Compare
|
The image is available at: |
kadel
force-pushed
the
build-multiplatform-next-image
branch
from
fbed803 to
7b9d684
Compare
|
The image is available at: |
| @@ -76,6 +68,7 @@ jobs: | |||
| # to autodelete PR image tags, set an expiry date | |||
| imageLabels: quay.expires-after=14d | |||
| push: true | |||
| platform: linux/amd64 | |||
There was a problem hiding this comment.
so PR builds are single-arch but next builds are dual-arch? 🤔 What if your contributor is on a Mac and wants to test their PR build?
There was a problem hiding this comment.
Yes, for now yes.
My plan is to do the PR images in followup PR.
As it will require small updates to e2e tests as well.
e2e tests should not wait for the whole multiplatform image to be built, as it can take 4+ hours. So we will need to reconfigure them to wait for the platform specific tag.
kadel
force-pushed
the
build-multiplatform-next-image
branch
from
76c02be to
36bda1f
Compare
|
lasr PR build failed with Previous build worked 5 days ago at https://quay.io/repository/rhdh-community/rhdh?tab=tags&tag=pr-2036 so either this is a transient glith w/ quay.io or you made the image too big? |
kadel
force-pushed
the
build-multiplatform-next-image
branch
from
36bda1f to
2c1d63d
Compare
|
@nickboldt can you give this another look? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 350a58b
into
redhat-developer:main
Description
This updates the build process for the next image (build from main branch)
It adds the arm64 image build. arm64 and amd64 are built in parallel.
Platform specific images are tagged with
next-{platform}. This is mainly to make the amd64 image available quickly (takes less than 40 min) for testing, as arm64 build can take 4 hours.After both builds are done, the
nextmultiplatform tag is pushed and can be used.Which issue(s) does this PR fix