Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Switch AKS tests to mapt and spot instances #1719

Closed
wants to merge 13 commits into from

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented Oct 2, 2024

Description

This PR is switching the AKS nightly tests from long running cluster (that goes to sleep and wake up) to a spot instance (that is created and then destroyed). This approach allows us to save costs on Azure and gives us a fresh cluster every time, to avoid hiccups that the long running clusters might encounter.

This PR depends on having the #1643 merged first, to be able to use different auth provider than GitHub for majority of tests. GitHub requires a static callback URL (which is not achievable with mapt, but might be in the future: redhat-developer/mapt#273). GitHub is also not the most stable auth provider and tests sometimes fail because of it.

The same approach as for AKS will be possible for GKE after mapt adds support: redhat-developer/mapt#290

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Oct 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rm3l for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/ok-to-test

@zdrapela zdrapela changed the title [WIP] Switch AKS tests to mapt [WIP] Switch AKS tests to mapt and spot instances Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/retest

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test images

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/retest-required

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test images

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test e2e

Copy link

openshift-ci bot commented Oct 2, 2024

@zdrapela: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-tests
  • /test images

Use /test all to run all jobs.

In response to this:

/test e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zdrapela
Copy link
Member Author

zdrapela commented Oct 2, 2024

/test e2e-tests

Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

Copy link

sonarqubecloud bot commented Oct 2, 2024

Copy link
Contributor

github-actions bot commented Oct 2, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1719!

@zdrapela
Copy link
Member Author

zdrapela commented Oct 8, 2024

/test e2e-tests

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 10, 2024

@zdrapela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 4a12d5f link true /test e2e-tests
ci/prow/images 4a12d5f link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zdrapela
Copy link
Member Author

zdrapela commented Dec 11, 2024

Closing in favor of openshift/release#59507

@zdrapela zdrapela closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants