fix(orchestrator):add view variables dialog #312
Merged
+67
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiorSoffer
requested review from
batzionb,
mareklibra and
gciavarrini
as code owners
Changed Packages
|
mareklibra
requested changes
Jan 23, 2025
| @@ -89,7 +97,11 @@ export const WorkflowInstancePageContent: React.FC<{ | |||
| ); | |||
|
|
|||
| const workflowdata = assessedInstance.instance?.workflowdata; | |||
| let instanceVariables; | |||
| let instanceVariables: { | |||
There was a problem hiding this comment.
Suggested change
| let instanceVariables: { | |
| let instanceVariables: WorkflowDataDTO; |
| setIsVariablesDialogOpen(prev => !prev); | ||
| }, []); | ||
|
|
||
| const VariablesDialogContent = () => ( |
There was a problem hiding this comment.
Nit: by moving this component out of this function and passing instanceVariables as its property, the code will be cleaner and the component will not be re-created with every run.
Anyway, not a big issue in that particular case.
mareklibra
approved these changes
Jan 27, 2025
added 2 commits
February 2, 2025 13:16
Signed-off-by: Lior Soffer <[email protected]>
Signed-off-by: Lior Soffer <[email protected]>
|
mareklibra
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve FLPATH-2001
long list case:
