Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Refactor the test GH Job using a matrix strategy #111

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Mar 14, 2025

Description of the change

There were some duplicate steps, and the only difference between the test-latest and test-next jobs was the image tag

Existing or Associated Issue(s)

Additional Information

See https://github.com/redhat-developer/rhdh-chart/actions/runs/13860233336/job/38786634529?pr=111 for an example of Workflow run that passed.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@openshift-ci openshift-ci bot requested review from nickboldt and tumido March 14, 2025 15:30
@rm3l rm3l force-pushed the refactor_test_gh_workflow_using_matrix_strategy branch from ea80b8d to 2bdde81 Compare March 14, 2025 15:33
@rm3l rm3l force-pushed the refactor_test_gh_workflow_using_matrix_strategy branch 2 times, most recently from 6eea7f5 to b271d46 Compare March 14, 2025 15:41
rm3l added 2 commits March 14, 2025 16:44
There were some duplicate steps, and the only difference was just the image tag
@rm3l rm3l force-pushed the refactor_test_gh_workflow_using_matrix_strategy branch from b271d46 to 48525f3 Compare March 14, 2025 15:45
@rm3l rm3l merged commit 1b29b52 into redhat-developer:main Mar 14, 2025
5 of 6 checks passed
@rm3l rm3l deleted the refactor_test_gh_workflow_using_matrix_strategy branch March 14, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant