Skip to content

Commit

Permalink
chore: RHIDP-3048: Add release name to dynamic-plugins configmap name (
Browse files Browse the repository at this point in the history
…#35)

The dynamic-plugins configmap currently has a hard-coded name of
'dynamic-plugins' which prevents having two Developer Hub installations
in the same namespace.

This pull request updates the name of the 'dynamic-plugins' configmap
to include the name of the release such as '<release>-dynamic-plugins'
which will alleviate this issue and allow multiple installations of
Developer Hub per namespace using Helm.
  • Loading branch information
coreydaley committed Jul 12, 2024
1 parent a40240b commit 0798e97
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.16.5
version: 2.16.6
2 changes: 1 addition & 1 deletion charts/backstage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# RHDH Backstage Helm Chart for OpenShift

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/rhdh-chart&style=flat-square)](https://artifacthub.io/packages/search?repo=rhdh-chart)
![Version: 2.16.5](https://img.shields.io/badge/Version-2.16.5-informational?style=flat-square)
![Version: 2.16.6](https://img.shields.io/badge/Version-2.16.6-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying Red Hat Developer Hub.
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/templates/dynamic-plugins-configmap.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
name: dynamic-plugins
name: {{ printf "%s-dynamic-plugins" .Release.Name }}
data:
dynamic-plugins.yaml: |
{{- include "common.tplvalues.render" ( dict "value"
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2587,7 +2587,7 @@
{
"configMap": {
"defaultMode": 420,
"name": "dynamic-plugins",
"name": "{{ printf \"%s-dynamic-plugins\" .Release.Name }}",
"optional": true
},
"name": "dynamic-plugins"
Expand Down
2 changes: 1 addition & 1 deletion charts/backstage/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ upstream:
- name: dynamic-plugins
configMap:
defaultMode: 420
name: dynamic-plugins
name: '{{ printf "%s-dynamic-plugins" .Release.Name }}'
optional: true
# Optional volume that allows exposing the `.npmrc` file (through a `dynamic-plugins-npmrc` secret)
# to be used when running `npm pack` during the dynamic plugins installation by the initContainer.
Expand Down

0 comments on commit 0798e97

Please sign in to comment.