-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Gradle 2.x plugin SDK-based build #783
base: main
Are you sure you want to change the base?
Conversation
re-work from @SCWells72 Signed-off-by: Stephane Bouchet <[email protected]>
fix self reviews Signed-off-by: Stephane Bouchet <[email protected]>
@SCWells72 there are several tests with Java LS which fail, have you some idea? |
Not sure. I believe tests passed 100% on my branch, but obviously lots of changes were needed to get it into proper shape. I'll be happy to check out this branch tomorrow after I get my own release out and investigate if it's not resolved by then. |
Signed-off-by: Stephane Bouchet <[email protected]>
Signed-off-by: Stephane Bouchet <[email protected]>
@sbouchet could you resolve conflicts please. It seems CI build is failling. What is the status of this PR? |
note that the preleminary work done by scott also failed, but with only one failure: |
@SCWells72 could you help us to fix those tests please? |
The issue with these Java-specific tests is that they register the extension I was able to work around this with some of them by changing the extension to There's one other failure in |
Ok a simple fix is to rename |
That doesn't quite work. That's pretty much what I did by changing the extension to |
Okay, I've addressed the Java-specific failures. I confess that I'm not sure how to contribute changes to another user's PR branch, so here are the modified files: Removing/restoring the file type association worked perfectly for the on-type formatting tests but not for the folding range tests, and vice-versa for the folding range tests, hence why there are two different solutions in these changes. This leaves only remaining failure in |
may close #761