Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-47709: [release-4.17] fix backport mistake #395

Merged

Conversation

vitus133
Copy link
Member

Fixes backport mistake that caused ptpStateChange event never to be sent

Fixes backport mistake that caused ptpStateChange event never to be sent
Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vitus133 vitus133 changed the title fix backport mistake OCPBUGS-47709: [release-4.17] fix backport mistake Dec 31, 2024
@openshift-ci-robot
Copy link

@vitus133: This pull request references Jira Issue OCPBUGS-47709, which is invalid:

  • expected Jira Issue OCPBUGS-47709 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes backport mistake that caused ptpStateChange event never to be sent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vitus133
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@vitus133: This pull request references Jira Issue OCPBUGS-47709, which is valid. The bug has been moved to the POST state.

9 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-46635 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent bug Jira Issue OCPBUGS-46635 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-46635 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • dependent Jira Issue OCPBUGS-46635 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

@vitus133: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security b8e8f58 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vitus133 vitus133 merged commit bdcc02b into redhat-cne:release-4.17 Dec 31, 2024
3 of 7 checks passed
@openshift-ci-robot
Copy link

@vitus133: Jira Issue OCPBUGS-47709: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-47709 has been moved to the MODIFIED state.

In response to this:

Fixes backport mistake that caused ptpStateChange event never to be sent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vitus133
Copy link
Member Author

/cherrypick release-4.16

@openshift-cherrypick-robot

@vitus133: new pull request created: #396

In response to this:

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.17.0-202412310807.p0.gbdcc02b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants