Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45866 : Fix GM State Transition Event Generation #380

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

vitus133
Copy link
Member

This is a cherrypick from #379
Previously, when the Grandmaster (GM) transitioned to the HOLDOVER state, an event was generated with the HOLDOVER status. However, subsequent state transitions from HOLDOVER to FREERUN or LOCKED did not trigger any events. This bug fix ensures that events are now correctly generated for transitions from HOLDOVER to FREERUN or LOCKED states.

This is a cherrypick from redhat-cne#379
Previously, when the Grandmaster (GM) transitioned to the HOLDOVER state, an event was generated with the HOLDOVER status. However, subsequent state transitions from HOLDOVER to FREERUN or LOCKED did not trigger any events.
This bug fix ensures that events are now correctly generated for transitions from HOLDOVER to FREERUN or LOCKED states.

Signed-off-by: Vitaly Grinberg <[email protected]>
@vitus133 vitus133 changed the title Fix GM State Transition Event Generation OCPBUGS-45866 : Fix GM State Transition Event Generation Dec 18, 2024
@vitus133
Copy link
Member Author

/approve

@vitus133
Copy link
Member Author

/cc @jzding

@openshift-ci openshift-ci bot requested a review from jzding December 18, 2024 11:56
@jzding
Copy link
Member

jzding commented Dec 18, 2024

the change in plugins/ptp_operator/metrics/metrics_test.go is missing. It will be great to add unit test coverage.

Signed-off-by: Vitaly Grinberg <[email protected]>
Copy link
Member

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jzding jzding merged commit 2a46db4 into redhat-cne:main Dec 18, 2024
3 of 5 checks passed
@vitus133
Copy link
Member Author

/cherrypick release-4.18

@openshift-cherrypick-robot

@vitus133: only redhat-cne org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vitus133
Copy link
Member Author

/cherrypick release-4.18

@openshift-cherrypick-robot

@vitus133: new pull request created: #381

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.19.0-202412191309.p0.g2a46db4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants