-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-46150: fix subscription for multiple clients #378
Conversation
7c39d95
to
d897209
Compare
@jzding: This pull request references Jira Issue OCPBUGS-46150, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jzding, vitus133 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d897209
to
ed65cb7
Compare
New changes are detected. LGTM label has been removed. |
Signed-off-by: Jack Ding <[email protected]>
ed65cb7
to
e5626e2
Compare
/jira refresh |
@jzding: This pull request references Jira Issue OCPBUGS-46150, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jzding: Jira Issue OCPBUGS-46150: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-46150 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: cloud-event-proxy |
/cherry-pick release-4.18 |
@jzding: new pull request created: #392 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Current code checking for existing subscription by resourceAddress only. This fix added checking for EndpointURI so that multiple clients (with different EndpointURIs) can create subscriptions for the same resourceAddress.