Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-46150: fix subscription for multiple clients #378

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jzding
Copy link
Member

@jzding jzding commented Dec 11, 2024

Current code checking for existing subscription by resourceAddress only. This fix added checking for EndpointURI so that multiple clients (with different EndpointURIs) can create subscriptions for the same resourceAddress.

@jzding jzding force-pushed the support-multi-clients branch from 7c39d95 to d897209 Compare December 13, 2024 23:36
@jzding jzding changed the title fix subscription for multiple clients [WIP] fix subscription for multiple clients Dec 16, 2024
@jzding jzding changed the title [WIP] fix subscription for multiple clients [WIP] OCPBUGS-46150: fix subscription for multiple clients Dec 16, 2024
@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-46150, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jzding jzding force-pushed the support-multi-clients branch from d897209 to ed65cb7 Compare December 17, 2024 21:09
@openshift-ci openshift-ci bot removed the lgtm label Dec 17, 2024
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

New changes are detected. LGTM label has been removed.

@jzding jzding force-pushed the support-multi-clients branch from ed65cb7 to e5626e2 Compare December 17, 2024 21:34
@jzding jzding changed the title [WIP] OCPBUGS-46150: fix subscription for multiple clients OCPBUGS-46150: fix subscription for multiple clients Dec 17, 2024
@jzding
Copy link
Member Author

jzding commented Dec 17, 2024

/jira refresh

@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-46150, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding jzding merged commit fdc29b1 into redhat-cne:main Dec 17, 2024
4 of 5 checks passed
@openshift-ci-robot
Copy link

@jzding: Jira Issue OCPBUGS-46150: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-46150 has been moved to the MODIFIED state.

In response to this:

Current code checking for existing subscription by resourceAddress only. This fix added checking for EndpointURI so that multiple clients (with different EndpointURIs) can create subscriptions for the same resourceAddress.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.19.0-202412180044.p0.gfdc29b1.assembly.stream.el9.
All builds following this will include this PR.

@jzding
Copy link
Member Author

jzding commented Dec 20, 2024

/cherry-pick release-4.18

@openshift-cherrypick-robot

@jzding: new pull request created: #392

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants