Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42840: cleanup configmap when event apiVersion change #361

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jzding
Copy link
Member

@jzding jzding commented Oct 10, 2024

Tests done:

  1. deploy ptp-operator, update ptpoperatorconfig to enable v1 event
  2. deploy v1 consumer => verify configmap and events
  3. update update ptpoperatorconfig to enable v2 event => verify configmap cleaned up
  4. undeploy v1 consumer and deploy v2 consumer => verify configmap and events
  5. reboot linuxptp-daemon pod => verify configmap and events
  6. reboot consumer => verify configmap and events
  7. reboot linuxptp-daemon pod again => verify configmap and events
  8. update ptpoperatorconfig to enable v1 event => verify configmap cleaned up
  9. undeploy v2 consumer and deploy v1 consumer => verify configmap and events
  10. reboot linuxptp-daemon pod => verify configmap and events

@jzding jzding changed the title cleanup configmap when event apiVersion change OCPBUGS-42840: cleanup configmap when event apiVersion change Oct 10, 2024
@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-42840, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding jzding changed the title OCPBUGS-42840: cleanup configmap when event apiVersion change [WIP] OCPBUGS-42840: cleanup configmap when event apiVersion change Oct 10, 2024
@jzding jzding force-pushed the cleanup-configmap branch from ba60b06 to db4ab75 Compare October 10, 2024 17:15
@openshift-ci-robot
Copy link

@jzding: This pull request references Jira Issue OCPBUGS-42840, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Tests to do:

  • deploy ptp-operator, update ptpoperatorconfig to enable v1 event
  • deploy v1 consumer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding jzding force-pushed the cleanup-configmap branch from 6f2fb5b to d9ccbf2 Compare October 11, 2024 14:03
@jzding jzding changed the title [WIP] OCPBUGS-42840: cleanup configmap when event apiVersion change OCPBUGS-42840: cleanup configmap when event apiVersion change Oct 11, 2024
@jzding jzding force-pushed the cleanup-configmap branch from d9ccbf2 to a38b8d2 Compare October 11, 2024 16:11
Copy link
Contributor

@nishant-parekh nishant-parekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, nishant-parekh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4620235 into redhat-cne:main Oct 11, 2024
5 checks passed
@openshift-ci-robot
Copy link

@jzding: Jira Issue OCPBUGS-42840: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42840 has been moved to the MODIFIED state.

In response to this:

Tests done:

  1. deploy ptp-operator, update ptpoperatorconfig to enable v1 event
  2. deploy v1 consumer => verify configmap and events
  3. update update ptpoperatorconfig to enable v2 event => verify configmap cleaned up
  4. undeploy v1 consumer and deploy v2 consumer => verify configmap and events
  5. reboot linuxptp-daemon pod => verify configmap and events
  6. reboot consumer => verify configmap and events
  7. reboot linuxptp-daemon pod again => verify configmap and events
  8. update ptpoperatorconfig to enable v1 event => verify configmap cleaned up
  9. undeploy v2 consumer and deploy v1 consumer => verify configmap and events
  10. reboot linuxptp-daemon pod => verify configmap and events

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jzding
Copy link
Member Author

jzding commented Oct 11, 2024

/cherry-pick release-4.17

@openshift-cherrypick-robot

@jzding: new pull request created: #362

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@aneeshkp aneeshkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cloud-event-proxy
This PR has been included in build cloud-event-proxy-container-v4.18.0-202410112106.p0.g4620235.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants