Use processor/client module name as thrift rpc service. #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should align us with the upcoming baseplate.go changes. reddit/baseplate.go#686
marcoferrer
reviewed
Feb 21, 2025
| @@ -220,12 +220,14 @@ def example(self, context): | |||
| thrift_client_span.get_span_context().span_id, | |||
| ) | |||
|
|
|||
| self.assertEqual(thrift_client_span.name, "example_service/example") | |||
| self.assertEqual( | |||
| thrift_client_span.name, "tests.integration.test_thrift.TestService/example" | |||
There was a problem hiding this comment.
So this contains the full python package name. To get something close to a "thrift" package, you'll need to only keep the last part of the package.
The assertion should be against test_thrift.TestService.
There was a problem hiding this comment.
The python file name usually maps to the thrift schema name.
There was a problem hiding this comment.
Sounds good, is it always only a single depth package? I should be able to just split on . and take the last element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to have both ends of the rpc class the same across frameworks, similar to how grpc operates.
This should align us with the upcoming baseplate.go changes.
reddit/baseplate.go#686
Closes #
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks