bug fix for passing thrift client name in interop #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoferrer
requested review from
fishy,
konradreiche and
pacejackson
and removed request for
a team
pacejackson
requested changes
Feb 11, 2025
fishy
requested changes
Feb 11, 2025
pacejackson
approved these changes
Feb 11, 2025
fishy
approved these changes
Feb 11, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
💸 TL;DR
Services transitioning to baseplate v2 have the service name missing from client traces. Right now its defaulting to
unknowndue to the interop library initializing a global tracer. This is the first change needed to resolve this bug. It is backwards compatible and allows us to rollout the fix gracefully.More details in internal obs thread.
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks