Bug 2059669: Delete manifestwork for application namespace #348
Conversation
Signed-off-by: Elena Gershkovich <[email protected]> (cherry picked from commit b870966)
Signed-off-by: Elena Gershkovich <[email protected]> (cherry picked from commit f24f0a8)
Updating kubernetes-csi-addon version demands also update in rook, because csi 0.9.0 requires sidecar 0.9.0 and cephcsi 3.12.0, that is rook 1.15 is bringing. Signed-off-by: Elena Gershkovich <[email protected]> (cherry picked from commit 0223e05)
Signed-off-by: Abhijeet Shakya <[email protected]> (cherry picked from commit 223d74a)
The changeset includes a new DeleteNamespaceManifestWork() func, which first checks if the mw.Spec has delete option or if it already has a DeletionTimestamp. Accordingly, it proceeds to delete the namespace manifestwork. It also updates the namespace manifestwork with the deleteOption and propogationPolicy of type orphan, whenever the createOrUpdateNamespaceManifest() func is called. Fixes: [Bug 2059669](https://bugzilla.redhat.com/show_bug.cgi?id=2059669) Signed-off-by: Abhijeet Shakya <[email protected]> (cherry picked from commit 9ffef9c)
Signed-off-by: Abhijeet Shakya <[email protected]> (cherry picked from commit 91ebfba)
|
@abhijeet219: This pull request references Bugzilla bug 2059669, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abhijeet219 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@ShyamsundarR: This pull request references Bugzilla bug 2059669, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keemano. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ShyamsundarR
merged commit 3ca5e4f
into
red-hat-storage:release-4.17
|
@abhijeet219: All pull requests linked via external trackers have merged: Bugzilla bug 2059669 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Changes:
The changeset includes a new DeleteNamespaceManifestWork() func to delete the manifestwork for namespace. It first checks if the mw.Spec has delete option or if it already has a DeletionTimestamp. Accordingly, it proceeds to delete the
namespace manifestwork.
Also introduces updating of the namespace manifestwork with the deleteOption and propogationPolicy of type orphan, whenever the createOrUpdateNamespaceManifest() func is called.
Fixes: Bug 2059669