Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2246638: DRCluster does not clear its condition after it is unfenced #295

Open
wants to merge 3 commits into
base: release-4.16
Choose a base branch
from

Conversation

ELENAGER
Copy link

The problem:
When a drcluster is fenced or unfenced and the operation is complete, ramen hub operator doesn't delete the manifestwork that it created to perform the operation. The manifestwork is therefore left to be reused for further operations on the same drcluster. When reused in such a manner, it is possible that the result condition from the previous operation is referred to by Ramen as the current state. This leads to a potential data corruption bug where Ramen allows for deployment of the apps on the failover cluster before the failed cluster is completely fenced.

The solution:
NF manifest work is not deleted after every unfence operation.

Signed-off-by: Elena Gershkovich <[email protected]>
(cherry picked from commit 161b3d0)
Signed-off-by: Elena Gershkovich <[email protected]>
(cherry picked from commit 716c02d)
Signed-off-by: Elena Gershkovich <[email protected]>
(cherry picked from commit 383a85d)
Copy link

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ELENAGER

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jun 11, 2024

@ELENAGER: This pull request references Bugzilla bug 2246638, which is invalid:

  • expected the bug to target the "ODF 4.16.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2246638: DRCluster does not clear its condition after it is unfenced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant