Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2232552: Find PlacementDecision by Placement label selector #124

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

ShyamsundarR
Copy link

PlacementDecisions created have a defined label carrying
the Placement for which it was created in the same
namespace as the Placement. This is a more deterministic
manner to find PlacementDecisions that are created for
a given Placement.

This commit removes the older scheme of depending on the
PlacementDecision naming scheme and moves to listing
PlacementDecisions by a label selector.

PlacementDecisions created have a defined label carrying
the Placement for which it was created in the same
namespace as the Placement. This is a more deterministic
manner to find PlacementDecisions that are created for
a given Placement.

This commit removes the older scheme of depending on the
PlacementDecision naming scheme and moves to listing
PlacementDecisions by a label selector.

Signed-off-by: Shyamsundar Ranganathan <[email protected]>
(cherry picked from commit 858c8b4)
As we create a PlacementDecision if we do not find one, it could
lead to conflicts on the name. This commit adds a retry with different
index values for the name, with a cap count of 5, to ensure some
defence against conflicts.

An ideal case would be to just use a uuid as the index, and avoid
conflicts across, but that needs some confirmation with OCM on the
PlacementDecision naming scheme and hence is not done at present.

Signed-off-by: Shyamsundar Ranganathan <[email protected]>
(cherry picked from commit f9514cc)
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@ShyamsundarR: This pull request references Bugzilla bug 2232552, which is invalid:

  • expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2232552: Find PlacementDecision by Placement label selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR merged commit b000cb7 into red-hat-storage:release-4.14 Aug 24, 2023
12 checks passed
@ShyamsundarR ShyamsundarR deleted the bz2232552-2 branch August 24, 2023 17:31
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

@ShyamsundarR: All pull requests linked via external trackers have merged:

Bugzilla bug 2232552 has been moved to the MODIFIED state.

In response to this:

Bug 2232552: Find PlacementDecision by Placement label selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant