Bug 2232552: Update hub RBAC to include Placement finalizer "update" #123
Conversation
Improves debuggability in terms of detecting where the error originated from, given the additional context. The added log line for Create was oterwise caught when looking at status update for DRPC and lacked context on where it was from. Signed-off-by: Shyamsundar Ranganathan <[email protected]> (cherry picked from commit 206e799)
As per [1] when setting owner references to a resource and specifically while setting blockOwnerDeletion to true, an RBAC to update the finalizer of the resource set as the owner is required. This commit adds the required RBAC for the same. [1] https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#ownerreferencespermissionenforcement Signed-off-by: Shyamsundar Ranganathan <[email protected]> (cherry picked from commit 11b7729)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ShyamsundarR The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ShyamsundarR: This pull request references Bugzilla bug 2232552, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShyamsundarR: All pull requests linked via external trackers have merged: Bugzilla bug 2232552 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As per [1] when setting owner references to a resource and
specifically while setting blockOwnerDeletion to true, an
RBAC to update the finalizer of the resource set as the owner
is required.
This commit adds the required RBAC for the same.
[1] https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#ownerreferencespermissionenforcement