Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2229567: Disable vrgNamespace caching to prevent upgrade issues #119

Conversation

raghavendra-talur
Copy link
Collaborator

Previously, we implemented a caching mechanism for vrgNamespace to optimize
the process of fetching the namespace of the application when it is part of
the ApplicationSet. However, this approach caused an upgrade problem when
moving from version 4.12 to 4.13. This commit will disable the vrgNamespace
caching until all customers have upgraded to version 4.13 or later.

Signed-off-by: Benamar Mekhissi [email protected]
(cherry picked from commit 572c9dc)

Benamar Mekhissi added 3 commits August 5, 2023 23:58
Previously, we implemented a caching mechanism for vrgNamespace to optimize
the process of fetching the namespace of the application when it is part of
the ApplicationSet. However, this approach caused an upgrade problem when
moving from version 4.12 to 4.13. This commit will disable the vrgNamespace
caching until all customers have upgraded to version 4.13 or later.

Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit 572c9dc)
Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit 5ee0ddb)
Introduce ordered initialization for the condition array in the DRPC module.
This change ensures that the conditions are consistently located in the array,
allowing for easier management and maintenance. Additionally, the updates made
to the code now properly preserve the order of the conditions, providing more
reliable and predictable behavior.

Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit e9a78fc)
@raghavendra-talur raghavendra-talur changed the title Disable vrgNamespace caching to prevent upgrade issues Bug 2229567: Disable vrgNamespace caching to prevent upgrade issues Aug 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

@raghavendra-talur: This pull request references Bugzilla bug 2229567, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2229567: Disable vrgNamespace caching to prevent upgrade issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@raghavendra-talur: This pull request references Bugzilla bug 2229567, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2229567: Disable vrgNamespace caching to prevent upgrade issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raghavendra-talur
Copy link
Collaborator Author

/lgtm /approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raghavendra-talur

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raghavendra-talur raghavendra-talur merged commit b7d724d into red-hat-storage:release-4.14 Aug 8, 2023
12 checks passed
@raghavendra-talur raghavendra-talur deleted the rtalur-backport-931 branch August 8, 2023 06:03
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

@raghavendra-talur: All pull requests linked via external trackers have merged:

Bugzilla bug 2229567 has been moved to the MODIFIED state.

In response to this:

Bug 2229567: Disable vrgNamespace caching to prevent upgrade issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant