-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2229567: Disable vrgNamespace caching to prevent upgrade issues #119
Bug 2229567: Disable vrgNamespace caching to prevent upgrade issues #119
Conversation
Previously, we implemented a caching mechanism for vrgNamespace to optimize the process of fetching the namespace of the application when it is part of the ApplicationSet. However, this approach caused an upgrade problem when moving from version 4.12 to 4.13. This commit will disable the vrgNamespace caching until all customers have upgraded to version 4.13 or later. Signed-off-by: Benamar Mekhissi <[email protected]> (cherry picked from commit 572c9dc)
Signed-off-by: Benamar Mekhissi <[email protected]> (cherry picked from commit 5ee0ddb)
Introduce ordered initialization for the condition array in the DRPC module. This change ensures that the conditions are consistently located in the array, allowing for easier management and maintenance. Additionally, the updates made to the code now properly preserve the order of the conditions, providing more reliable and predictable behavior. Signed-off-by: Benamar Mekhissi <[email protected]> (cherry picked from commit e9a78fc)
@raghavendra-talur: This pull request references Bugzilla bug 2229567, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 2 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm /approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: raghavendra-talur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b7d724d
into
red-hat-storage:release-4.14
@raghavendra-talur: All pull requests linked via external trackers have merged: Bugzilla bug 2229567 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously, we implemented a caching mechanism for vrgNamespace to optimize
the process of fetching the namespace of the application when it is part of
the ApplicationSet. However, this approach caused an upgrade problem when
moving from version 4.12 to 4.13. This commit will disable the vrgNamespace
caching until all customers have upgraded to version 4.13 or later.
Signed-off-by: Benamar Mekhissi [email protected]
(cherry picked from commit 572c9dc)